Remove #error and fallback to AVX2 when compiled with just -mavx512f for static methods #212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. I can confirm that after applying this diff to the file in NumPy, it builds for me with the relevant compiler flags. |
r-devulap
force-pushed
the
buildfix-knl
branch
from
61e7e0a to
b2aa26b
Compare
r-devulap
force-pushed
the
buildfix-knl
branch
from
b2aa26b to
f3c224a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See numpy/numpy#29560 for build failure on KNL.
Removed the error directive that prevented use of AVX512F alone, allowing AVX2 support even when AVX512F is defined, which improves compatibility on systems with mixed instruction set support.